feat(cognito): specifying the trigger event version in UserPool.addTrigger()#28899
Merged
mergify[bot] merged 15 commits intoaws:mainfrom Feb 2, 2024
Merged
feat(cognito): specifying the trigger event version in UserPool.addTrigger()#28899mergify[bot] merged 15 commits intoaws:mainfrom
mergify[bot] merged 15 commits intoaws:mainfrom
Conversation
f5e7250 to
a0db50a
Compare
aaythapa
reviewed
Feb 1, 2024
Contributor
aaythapa
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Overall looks great, just some nitpicks
...cdk-testing/framework-integ/test/aws-cognito/test/integ.user-pool-pre-token-generation-v2.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
aaythapa
approved these changes
Feb 2, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
…igger() (#28899) I have added a `lambdaVersion` to the `UserPool.addTrigger()`. This is in response to the [support for V2.0 trigger event in preTokenGeneration](https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-pre-token-generation.html). ```ts declare const userpool: cognito.UserPool; declare const preTokenGenerationFn: lambda.Function; userpool.addTrigger(cognito.UserPoolOperation.PRE_TOKEN_GENERATION_CONFIG, preTokenGenerationFn, LambdaVersion.V2_0); ``` In #28683, apart from the current implementation approach, there was also a proposal to add `lambdaVersion` to `UserPoolProps.lambdaTrigger`. However, it was not adopted as it would result in a breaking change. Closes #28683 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra
pushed a commit
that referenced
this pull request
Feb 9, 2024
…igger() (#28899) I have added a `lambdaVersion` to the `UserPool.addTrigger()`. This is in response to the [support for V2.0 trigger event in preTokenGeneration](https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-pre-token-generation.html). ```ts declare const userpool: cognito.UserPool; declare const preTokenGenerationFn: lambda.Function; userpool.addTrigger(cognito.UserPoolOperation.PRE_TOKEN_GENERATION_CONFIG, preTokenGenerationFn, LambdaVersion.V2_0); ``` In #28683, apart from the current implementation approach, there was also a proposal to add `lambdaVersion` to `UserPoolProps.lambdaTrigger`. However, it was not adopted as it would result in a breaking change. Closes #28683 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a
lambdaVersionto theUserPool.addTrigger().This is in response to the support for V2.0 trigger event in preTokenGeneration.
In #28683, apart from the current implementation approach, there was also a proposal to add
lambdaVersiontoUserPoolProps.lambdaTrigger. However, it was not adopted as it would result in a breaking change.Closes #28683
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license