feat(ecs): idleTimeout and perRequestTimeout for service connect#28877
Merged
mergify[bot] merged 9 commits intoaws:mainfrom Feb 2, 2024
Merged
feat(ecs): idleTimeout and perRequestTimeout for service connect#28877mergify[bot] merged 9 commits intoaws:mainfrom
idleTimeout and perRequestTimeout for service connect#28877mergify[bot] merged 9 commits intoaws:mainfrom
Conversation
lpizzinidev
suggested changes
Jan 27, 2024
Contributor
lpizzinidev
left a comment
There was a problem hiding this comment.
Looks good overall 👍
I left some suggestions for improvements.
Comment on lines
+248
to
+253
| * Can only be set when the appProtocol for application container is HTTP/HTTP2/GRPC. | ||
| * | ||
| * If `idleTimeout` is set to a time that is less than `perRequestTimeout`, the connection will close | ||
| * when the `idleTimeout` is reached and not the `perRequestTimeout`. | ||
| * | ||
| * @default Duration.seconds(15) |
Contributor
There was a problem hiding this comment.
Suggested change
| * Can only be set when the appProtocol for application container is HTTP/HTTP2/GRPC. | |
| * | |
| * If `idleTimeout` is set to a time that is less than `perRequestTimeout`, the connection will close | |
| * when the `idleTimeout` is reached and not the `perRequestTimeout`. | |
| * | |
| * @default Duration.seconds(15) | |
| * Can only be set when the `appProtocol` for the application container is HTTP/HTTP2/GRPC. | |
| * | |
| * If `idleTimeout` is set to a time that is less than `perRequestTimeout`, the connection will close | |
| * when the `idleTimeout` is reached and not the `perRequestTimeout`. | |
| * | |
| * @default - Duration.seconds(15) |
add an unit test
Contributor
Author
|
Thank you! I fixed them. |
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
kaizencc
reviewed
Feb 2, 2024
idleTimeout and perRequestTimeout for service connect
kaizencc
approved these changes
Feb 2, 2024
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Thanks for the contribution + the review :)
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
…28877) This PR supports the timeout configuration for Service Connect. Release https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-ecs-configurable-timeout-service-connect/ Developer guide https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service-connect-concepts.html#service-connect-concepts-proxy CloudFormation https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-serviceconnectservice.html#cfn-ecs-service-serviceconnectservice-timeout https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-timeoutconfiguration.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra
pushed a commit
that referenced
this pull request
Feb 9, 2024
…28877) This PR supports the timeout configuration for Service Connect. Release https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-ecs-configurable-timeout-service-connect/ Developer guide https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service-connect-concepts.html#service-connect-concepts-proxy CloudFormation https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-serviceconnectservice.html#cfn-ecs-service-serviceconnectservice-timeout https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-timeoutconfiguration.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the timeout configuration for Service Connect.
Release
https://aws.amazon.com/about-aws/whats-new/2024/01/amazon-ecs-configurable-timeout-service-connect/
Developer guide
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service-connect-concepts.html#service-connect-concepts-proxy
CloudFormation
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-serviceconnectservice.html#cfn-ecs-service-serviceconnectservice-timeout
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-timeoutconfiguration.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license