fix(cloudwatch): Math:UnknownIdentifier warning for INSIGHT_RULE_METRIC#28870
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Feb 6, 2024
Merged
fix(cloudwatch): Math:UnknownIdentifier warning for INSIGHT_RULE_METRIC#28870mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
The CloudWatch MathExpression class warns about identifiers missing from usingMetrics when INSIGHT_RULE_METRIC is used in the expression. It incorrectly parses the arguments to INSIGHT_RULE_METRIC as identifiers. When using INSIGHT_RULE_METRIC, I don't believe there is anything that needs to be added to usingMetrics.
aws-cdk-automation
previously requested changes
Jan 25, 2024
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Contributor
Author
|
Exemption Request |
kaizencc
approved these changes
Feb 6, 2024
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Thanks, looks good to me
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
that referenced
this pull request
Feb 9, 2024
…IC (#28870) The CloudWatch `MathExpression` class warns about identifiers missing from `usingMetrics` when `INSIGHT_RULE_METRIC` is used in the expression. It incorrectly parses the arguments to `INSIGHT_RULE_METRIC` as identifiers. When using `INSIGHT_RULE_METRIC`, I don't believe there is anything that needs to be added to `usingMetrics`. This implementation follows a similar fix done for some other expressions here: #24313 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CloudWatch
MathExpressionclass warns about identifiers missing fromusingMetricswhenINSIGHT_RULE_METRICis used in the expression. It incorrectly parses the arguments toINSIGHT_RULE_METRICas identifiers. When usingINSIGHT_RULE_METRIC, I don't believe there is anything that needs to be added tousingMetrics.This implementation follows a similar fix done for some other expressions here: #24313
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license