feat(autoscaling): `datapointsToAlarm` property for step scaling policy by go-to-k · Pull Request #28792 · aws/aws-cdk

go-to-k · 2024-01-20T13:37:15Z

This PR adds a property datapointsToAlarm for StepScalingPolicy.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍
I left some notes for minor adjustments.

packages/aws-cdk-lib/aws-autoscaling/test/scaling.test.ts

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts

go-to-k · 2024-01-21T05:38:28Z

@lpizzinidev

Thanks for your review. I fixed.

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts

lpizzinidev

Thanks 👍

aaythapa

Thank you for your contribution! Looks good overall, some minor comments/questions

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts

go-to-k · 2024-01-23T00:41:03Z

@aaythapa

Thanks for your review. I changed.

aaythapa

🚀

mergify · 2024-01-23T18:12:43Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-01-23T18:16:46Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

mergify · 2024-01-23T18:52:59Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-01-23T19:22:10Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 02dc332
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-01-23T19:22:37Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…ointsToAlarm` for step scaling policy (#28880) This PR adds validations for `evaluationPeriods` and `datapointsToAlarm` for step scaling policy. It is based on [the PR for datapointsToAlarm in autoscaling step scaling policy](#28792). Check the following cases: - `evaluationPeriods` < 1 - `datapointsToAlarm` is set, and - `evaluationPeriods` is not set - `datapointsToAlarm` < 1 - `evaluationPeriods` < `datapointsToAlarm` These validations also consider whether those parameters are tokens or not. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(autoscaling): property for step scaling policy

8cdd9c1

aws-cdk-automation requested a review from a team January 20, 2024 13:37

github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jan 20, 2024

go-to-k changed the title ~~feat(autoscaling): property for step scaling policy~~ feat(autoscaling): datapointsToAlarm property for step scaling policy Jan 20, 2024

aws-cdk-automation previously requested changes Jan 20, 2024

View reviewed changes

go-to-k added 3 commits January 20, 2024 22:53

unit tests

88c42c1

README

258518c

add integ test

c635384

go-to-k marked this pull request as ready for review January 20, 2024 14:41

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 20, 2024

change Error

f29a4ce

lpizzinidev suggested changes Jan 20, 2024

View reviewed changes

packages/aws-cdk-lib/aws-autoscaling/test/scaling.test.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 20, 2024

go-to-k added 2 commits January 21, 2024 14:10

change doc and unit tests

6677872

add validation

e9293f7

go-to-k requested a review from lpizzinidev January 21, 2024 05:38

go-to-k commented Jan 21, 2024

View reviewed changes

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved

lpizzinidev approved these changes Jan 21, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 21, 2024

aaythapa reviewed Jan 22, 2024

View reviewed changes

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved

packages/aws-cdk-lib/aws-autoscaling/lib/step-scaling-policy.ts Outdated Show resolved Hide resolved

add validation for only datapointsToAlarm

add2947

go-to-k requested a review from aaythapa January 23, 2024 00:40

go-to-k added 2 commits January 23, 2024 09:48

handling for token

8dba817

add validation for evaluationPeriods without datapointsToAlarm

40a50d4

aaythapa previously approved these changes Jan 23, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 23, 2024

Merge branch 'main' into asg-datapoints-step-scale

ff162e2

aaythapa approved these changes Jan 23, 2024

View reviewed changes

Merge branch 'main' into asg-datapoints-step-scale

02dc332

mergify bot merged commit baf2bfb into aws:main Jan 23, 2024

go-to-k mentioned this pull request Jan 26, 2024

feat(applicationautoscaling): validate evaluationPeriods and datapointsToAlarm for step scaling policy #28880

Merged

github-actions bot mentioned this pull request Feb 1, 2024

Monthly PR metrics report - Jan 2024 #28952

Closed

Conversation

go-to-k commented Jan 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

go-to-k commented Jan 21, 2024

Uh oh!

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

aaythapa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

go-to-k commented Jan 23, 2024

Uh oh!

aaythapa left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jan 23, 2024

Uh oh!

mergify bot commented Jan 23, 2024

Uh oh!

mergify bot commented Jan 23, 2024

Uh oh!

aws-cdk-automation commented Jan 23, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Jan 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

go-to-k commented Jan 20, 2024 •

edited

Loading

aaythapa left a comment •

edited

Loading