fix(stepfunctions-tasks): mediapackagevod service generates wrong action in role policy#28775
Merged
mergify[bot] merged 6 commits intoaws:mainfrom Jan 31, 2024
Conversation
aws-cdk-automation
previously requested changes
Jan 19, 2024
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aaythapa
reviewed
Jan 25, 2024
Contributor
aaythapa
left a comment
There was a problem hiding this comment.
Thank you for the contribution! Everything looks good, just some small documentation nitpicks
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Show resolved
Hide resolved
aaythapa
previously approved these changes
Jan 31, 2024
Pull request has been modified.
aaythapa
approved these changes
Jan 31, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
…ion in role policy (#28775) When we use CallAwsService for Step Functions task, CDK generates IAM policy to grant permission regarding the API call. However, if we specify `mediapackagevod` as service in CallAwsService, CDK generates wrong policy statement such as `mediapackagevod:deleteAsset`. Correct service prefix for MediaPackageVOD is `mediapackage-vod`. https://docs.aws.amazon.com/service-authorization/latest/reference/list_awselementalmediapackagevod.html > Amazon MediaPackageVOD (service prefix: mediapackage-vod) provides the following service-specific resources, actions, and condition context keys for use in IAM permission policies. This PR solves the issue by adding mediapackagevod into iamServiceMap. This is similar with #27623 and #28082. Closes #28774. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use CallAwsService for Step Functions task, CDK generates IAM policy to grant permission regarding the API call. However, if we specify
mediapackagevodas service in CallAwsService, CDK generates wrong policy statement such asmediapackagevod:deleteAsset. Correct service prefix for MediaPackageVOD ismediapackage-vod.https://docs.aws.amazon.com/service-authorization/latest/reference/list_awselementalmediapackagevod.html
This PR solves the issue by adding mediapackagevod into iamServiceMap. This is similar with #27623 and #28082.
Closes #28774.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license