Skip to content

fix(CLI): cdk diff is not clear enough about using read-only change sets#28741

Merged
mergify[bot] merged 5 commits intomainfrom
comcalvi/changeset-messaging
Jan 18, 2024
Merged

fix(CLI): cdk diff is not clear enough about using read-only change sets#28741
mergify[bot] merged 5 commits intomainfrom
comcalvi/changeset-messaging

Conversation

@comcalvi
Copy link
Copy Markdown
Contributor

Updates the messaging from diff when creating a changeset to clarify that the changeset will not be deployed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2024 17:01
@github-actions github-actions bot added the p2 label Jan 17, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 17, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 17, 2024
@rix0rrr rix0rrr changed the title fix(CLI): update diff's changeset messaging to be less scary fix(CLI): cdk diff is not clear enough about using read-only change sets Jan 17, 2024
@rix0rrr rix0rrr added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 17, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 17, 2024 17:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 17, 2024
@comcalvi comcalvi force-pushed the comcalvi/changeset-messaging branch from 31f8d5b to a4e6d5c Compare January 18, 2024 20:34
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e620cf0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit bb50f97 into main Jan 18, 2024
@mergify mergify bot deleted the comcalvi/changeset-messaging branch January 18, 2024 21:27
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Jan 22, 2024
#28741 accidentally broke the logic that skips them

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants