feat(ecs): support for capacity provider managed instance draining#28672
feat(ecs): support for capacity provider managed instance draining#28672mergify[bot] merged 8 commits intomainfrom
Conversation
… rerun the integ test stack, and modify some license files to build successfully
# Conflicts: # packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES
| this.enableManagedDraining = props.enableManagedDraining; | ||
|
|
||
| let managedDraining = undefined; | ||
| if (this.enableManagedDraining != undefined) { | ||
| managedDraining = this.enableManagedDraining ? 'ENABLED' : 'DISABLED'; | ||
| } |
There was a problem hiding this comment.
nit: I wonder is there any differences when managedDraining is underfined or DISABLED? Can we set it to DISABLED first and change to ENABLED when enableManagedDraining is set?
xazhao
left a comment
There was a problem hiding this comment.
LGTM! Left a small comment but it's not a blocker.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…28672) ECS now supports managed instance draining which facilitates graceful termination of Amazon ECS instances for Capacity Providers. Add a new constructor property, `enableManagedDraining`, to `AsgCapacityProvider`, to allow users to enable this feature. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit aaa2a09)
ECS now supports managed instance draining which facilitates graceful termination of Amazon ECS instances for Capacity Providers.
Add a new constructor property,
enableManagedDraining, toAsgCapacityProvider, to allow users to enable this feature.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license