fix(cli): direct deploy method fails when there are no updates#28523
fix(cli): direct deploy method fails when there are no updates#28523mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
This is correctly handled for empty change sets here: https://github.com/aws/aws-cdk/blob/9d8b06f6478a98e01e3aaa86c1dbf22d6e861f05/packages/aws-cdk/lib/api/util/cloudformation.ts#L290-L296 but not for direct updates.
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request This change doesn't need an integ test. |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
go-to-k
left a comment
There was a problem hiding this comment.
Looks good!
(I made a comment that I misunderstood and deleted that.)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…8523) This is correctly handled for empty change sets here: https://github.com/aws/aws-cdk/blob/9d8b06f6478a98e01e3aaa86c1dbf22d6e861f05/packages/aws-cdk/lib/api/util/cloudformation.ts#L290-L296 but not for direct updates. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is correctly handled for empty change sets here:
aws-cdk/packages/aws-cdk/lib/api/util/cloudformation.ts
Lines 290 to 296 in 9d8b06f
but not for direct updates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license