Skip to content

feat(codepipeline-actions): more convenient methods to CacheControl#28491

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
Tietew:cpactions-cachecontrol-methods
Dec 30, 2023
Merged

feat(codepipeline-actions): more convenient methods to CacheControl#28491
mergify[bot] merged 2 commits intoaws:mainfrom
Tietew:cpactions-cachecontrol-methods

Conversation

@Tietew
Copy link
Copy Markdown
Contributor

@Tietew Tietew commented Dec 26, 2023

This PR adds following convenient methods to CacheControl; same as #25477.

method directive RFC
CacheControl.noStore() no-store RFC9111, Section 5.2.2.4
CacheControl.mustUnderstand() must-understand RFC9111, Section 5.2.2.3
CacheControl.immutable() immutable RFC8246
CacheControl.staleWhileRevalidate(duration) stale-while-revalidate=<duration> RFC5861
CacheControl.staleIfError(duration) stale-if-error=<duration> RFC5861

For more information about these Cache-Control directives,
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 26, 2023 03:39
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Dec 26, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Tietew
Copy link
Copy Markdown
Contributor Author

Tietew commented Dec 26, 2023

Exemption Request

The README does not refer CacheControl in S3DeployAction section currently.
There are no integration tests for CacheControl directives.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 26, 2023
@kaizencc kaizencc changed the title feat(codepipeline-actions): add some convenient methods to CacheControl feat(codepipeline-actions): more convenient methods to CacheControl Dec 30, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Dec 30, 2023
kaizencc
kaizencc approved these changes Dec 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 30, 2023 12:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 30, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 30, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b10f1b7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a59dc0c into aws:main Dec 30, 2023
@Tietew Tietew deleted the cpactions-cachecontrol-methods branch December 31, 2023 09:06
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@Tietew @paulhcsun
feat(codepipeline-actions): more convenient methods to CacheControl (…
366a946 
…aws#28491)

This PR adds following convenient methods to `CacheControl`; same as aws#25477.

| method | directive | RFC |
|-|-|-|
| `CacheControl.noStore()` | `no-store` | [RFC9111](https://www.rfc-editor.org/rfc/rfc9111.html), Section 5.2.2.4 |
| `CacheControl.mustUnderstand()` | `must-understand` | RFC9111, Section 5.2.2.3 |
| `CacheControl.immutable()` | `immutable` | [RFC8246](https://www.rfc-editor.org/rfc/rfc8246.html) |
| `CacheControl.staleWhileRevalidate(duration)` | `stale-while-revalidate=<duration>` | [RFC5861](https://www.rfc-editor.org/rfc/rfc5861.html) |
| `CacheControl.staleIfError(duration)` | `stale-if-error=<duration>` | RFC5861 |

For more information about these Cache-Control directives,
see https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tietew @aws-cdk-automation @kaizencc