Skip to content

feat(ec2): add dual stack vpc support#28480

Merged
mergify[bot] merged 93 commits intoaws:mainfrom
scanlonp:designIpv6Vpc
Jan 12, 2024
Merged

feat(ec2): add dual stack vpc support#28480
mergify[bot] merged 93 commits intoaws:mainfrom
scanlonp:designIpv6Vpc

Conversation

@scanlonp
Copy link
Copy Markdown
Contributor

@scanlonp scanlonp commented Dec 23, 2023

Adds parameter to configure a dual stack vpc, ipProtocol: ec2.IpProtocol.DUAL_STACK.

By default a dual stack vpc will:

  • Create an Amazon provided IPv6 CIDR block (/56) and associate it to the VPC.
  • Assign a portion of the block to each of the subnets (/64)
  • Enable autoassigning an IPv6 address for each subnet
  • Disable autoassigning public IPv4 addresses for each subnet
  • Create an Egress Only Internet Gateway for private subnets
  • Configure IPv6 routes for IGWs and EIGWs

Addresses #894.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@scanlonp
Copy link
Copy Markdown
Contributor Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 11, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@scanlonp scanlonp marked this pull request as ready for review January 11, 2024 19:58
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 11, 2024
@scanlonp scanlonp removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 11, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 11, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 12, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 911a995
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit caf83f1 into aws:main Jan 12, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 12, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Jan 12, 2024
Adds parameter to configure a dual stack vpc, `vpcProtocol: ec2.VpcProtocol.DUAL_STACK`.

By default a dual stack vpc will:

- Create an Amazon provided IPv6 CIDR block (/56) and associate it to the VPC.
- Assign a portion of the block to each of the subnets (/64)
- Enable autoassigning an IPv6 address for each subnet
- **Disable autoassigning public IPv4 addresses** for each subnet
- Create an Egress Only Internet Gateway for private subnets
- Configure IPv6 routes for IGWs and EIGWs

Addresses #894.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@@ -1809,11 +1813,7 @@ export class Vpc extends VpcBase {
privateSubnet.node.addDependency(this.ipv6CidrBlock);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt Isolated subnet also be added here to prevent a racecondition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants