feat(cloudfront): Key Value Store L2#28473
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
78d19e6 to
32c30de
Compare
This adds an initial resource to support creating a Key Value Store and specifying an import source. Unfortunately, CloudFormation doesn't seem to support specifying the `KeyValueStoreAssociations` property of a function so there isn't a way to actually associate the store with a function.
32c30de to
6b8ca8e
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
kaizencc
left a comment
There was a problem hiding this comment.
This looks great @kylelaker
packages/aws-cdk-lib/aws-cloudfront/test/key-value-store.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-cloudfront/test/key-value-store.test.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-cloudfront/test/key-value-store.test.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This adds an initial resource to support creating a Key Value Store and specifying an import source. Unfortunately, CloudFormation doesn't seem to support specifying the `KeyValueStoreAssociations` property of a function so there isn't a way to actually associate the store with a function. Closes aws#28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This adds an initial resource to support creating a Key Value Store and
specifying an import source. Unfortunately, CloudFormation doesn't seem
to support specifying the
KeyValueStoreAssociationsproperty of afunction so there isn't a way to actually associate the store with a
function.
Closes #28377.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license