fix(events-targets): imported sqs queue cannot be used as a rule dlq (#28165)#28285
fix(events-targets): imported sqs queue cannot be used as a rule dlq (#28165)#28285mergify[bot] merged 9 commits intoaws:mainfrom JeromeGuyon:fix/event-targets-imported-dlq
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request, this is covered by unit tests. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
kaizencc
left a comment
There was a problem hiding this comment.
Thanks @JeromeGuyon. I'm not entirely sure if sameEnvDimension is doing what we want anymore, but I think this is a good solution to get out the door and fix the issue.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#28165) (aws#28285) This PR fixes the bug where imported SQS queue cannot be used as Rule DeadLetterQueue, since fromQueueArn can resolve region and account from v2.109.0 Closes aws#28165 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR fixes the bug where imported SQS queue cannot be used as Rule DeadLetterQueue, since fromQueueArn can resolve region and account from v2.109.0
Closes #28165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license