feat(cli): warn of non-existent stacks in cdk destroy#27921
feat(cli): warn of non-existent stacks in cdk destroy#27921mergify[bot] merged 36 commits intoaws:mainfrom
cdk destroy#27921Conversation
This reverts commit 56293ef.
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: this should be covered with cli-integ tests. In my environment, the behavior was confirmed as expected. |
|
Hey, thank you for opening a contribution with us. |
|
@vinayak-kukreja Thanks. Glad to have them see that again. |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
@vinayak-kukreja @SankyRed @TheRealAmazonKendra If this state continues, this PR will be closed again. Could you please take a look at this? |
|
Hi @go-to-k, I'm very sorry for not getting back to you on this, we were in a state of waiting for another team but this was on me for not noticing your comments. I'm running the CLI integ tests through the pipeline now and will update you with the results soon. After which I will delegate this review to someone with more knowledge on the CDK CLI. |
|
@paulhcsun Thank you! I'm looking forward to hearing from you and the team after this! |
|
Apologies @go-to-k, there were some additional runs queued in the pipeline before this one so I couldn't check the results in time. It looks like it was skipped for some reason though, I will retry running it now. I just did a search and it looks like the last run on Jan 24th passed all tests. It should be fine to add the |
|
@go-to-k I've added the |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…)" This reverts commit f0d1d67.
…9577) Reverts #27921 Failing in the test pipeline on [this test](https://github.com/aws/aws-cdk/blob/07ce8ecc42782475d099b89944571375341c28d3/packages/%40aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts#L190) where it was not erroring out as it should have. [The error here](https://github.com/aws/aws-cdk/blob/07ce8ecc42782475d099b89944571375341c28d3/packages/aws-cdk/lib/api/cxapp/cloud-executable.ts#L86) is not being thrown.
This PR for cli is to warn if stacks with wrong cases (=not exist) specified in `cdk destroy`. Closes aws#27179. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s#29577) Reverts aws#27921 Failing in the test pipeline on [this test](https://github.com/aws/aws-cdk/blob/07ce8ecc42782475d099b89944571375341c28d3/packages/%40aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts#L190) where it was not erroring out as it should have. [The error here](https://github.com/aws/aws-cdk/blob/07ce8ecc42782475d099b89944571375341c28d3/packages/aws-cdk/lib/api/cxapp/cloud-executable.ts#L86) is not being thrown.
This PR for cli is to warn if stacks with wrong cases (=not exist) specified in
cdk destroy.Closes #27179.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license