feat(eks): add AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2#27910
Merged
mergify[bot] merged 3 commits intoaws:mainfrom Nov 10, 2023
Merged
feat(eks): add AlbControllerVersion v2.5.2 - v2.5.4 and v2.6.0 - v2.6.2#27910mergify[bot] merged 3 commits intoaws:mainfrom
mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
scanlonp
previously approved these changes
Nov 10, 2023
Contributor
scanlonp
left a comment
There was a problem hiding this comment.
Good addition, good tests, good docs. The history shows why app version and version are not on the same track for the v2.5.x versions.
The Kubernetes version increase is necessary as versions past 2.5.0 require Kubernetes 1.22+.
Pull request has been modified.
scanlonp
approved these changes
Nov 10, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mikewrighton
pushed a commit
that referenced
this pull request
Nov 13, 2023
….2 (#27910) This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2. See the [aws-load-balancer-controller releases](https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases). Each version to correspond to eks-chart versions is based on [aws-load-balancer-controller/Chart.yaml history](https://github.com/aws/eks-charts/commits/master/stable/aws-load-balancer-controller/Chart.yaml). For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts. https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml ```yaml apiVersion: v2 name: aws-load-balancer-controller description: AWS Load Balancer Controller Helm chart for Kubernetes version: 1.6.2 appVersion: v2.6.2 ``` Closes #27890. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds AlbControllerVersion v2.5.2 - v2.5.4, and v2.6.0 - v2.6.2.
See the aws-load-balancer-controller releases.
Each version to correspond to eks-chart versions is based on aws-load-balancer-controller/Chart.yaml history.
For example, v2.6.2 for AlbControllerVersion is to v1.6.2 for charts.
https://github.com/aws/eks-charts/blob/a644fd925ca091d881b3a42aace268322f484455/stable/aws-load-balancer-controller/Chart.yaml
Closes #27890.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license