fix: duration doesn't get accurately compared in multi alb service base#27664
fix: duration doesn't get accurately compared in multi alb service base#27664mergify[bot] merged 6 commits intoaws:mainfrom markanderstam:patch-1
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
...ges/aws-cdk-lib/aws-ecs-patterns/lib/base/application-multiple-target-groups-service-base.ts
Outdated
Show resolved
Hide resolved
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
scanlonp
left a comment
There was a problem hiding this comment.
Thanks for the integ test update!
Last thing, do not think we need to update yarn.lock. Mind removing the change from the PR unless it is necessary?
Pull request has been modified.
Sorry about that, I will revert that change. (Also, didn't realize that "Remove file" from the file viewer actually deleted the file and not the changes 😄 .. fixing..) |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…se (#27664) Duration wasn't getting compared correctly and prevented some values, eg between 5 and 9 or 500 and 999 (perhaps others as well), from getting used for `ApplicationMultipleTargetGroupsService.idleTimeout`. Relates to #21584, that fixes this issue for ApplicationLoadBalancedService (however the problem description was not fully correct in regards to what range of values were getting denied). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Duration wasn't getting compared correctly and prevented some values, eg between 5 and 9 or 500 and 999 (perhaps others as well), from getting used for
ApplicationMultipleTargetGroupsService.idleTimeout.Relates to #21584, that fixes this issue for ApplicationLoadBalancedService (however the problem description was not fully correct in regards to what range of values were getting denied).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license