Skip to content

feat(elasticloadbalancingv2): dualstack NetworkLoadBalancer#27546

Merged
mergify[bot] merged 7 commits intoaws:mainfrom
lpizzinidev:gh-27538
Dec 24, 2023
Merged

feat(elasticloadbalancingv2): dualstack NetworkLoadBalancer#27546
mergify[bot] merged 7 commits intoaws:mainfrom
lpizzinidev:gh-27538

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev commented Oct 14, 2023 •
edited
Loading

Adds support for dual-stack NetworkLoadBalancer via the ipAddressType property.

Example:

const lb = new elbv2.NetworkLoadBalancer(this, 'LB', {
  vpc,
  internetFacing: true
  ipAddressType: elbv2.IpAddressType.DUAL_STACK,
});

Also, added validation to enforce that UDP or TCP_UDP listeners cannot be added to a dualstack NLB.

Closes #27538.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Oct 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 14, 2023 17:01
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 15, 2023
@jaredlundell
Copy link
Copy Markdown

jaredlundell commented Oct 18, 2023

Dualstack NLBs are not required to be internet-facing. The only requirement is that the subnets it is placed in support IPv6. See https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-ip-address-type.html

@lpizzinidev
Copy link
Copy Markdown
Contributor Author

lpizzinidev commented Oct 19, 2023

@jaredlundell
Thanks for the feedback.
I added the validation because of the helper shown on the console when creating a NLB:

Screenshot 2023-10-19 at 08 46 04

If the load balancer is an internal load balancer, or if you add a UDP or TCP_UDP listener, you must choose IPv4.

Not sure if I misinterpreted it or if there is a documentation inconsistency.

laurelmay
laurelmay approved these changes Oct 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@laurelmay laurelmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool to have! Thanks for the work on this!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 19, 2023
@jaredlundell
Copy link
Copy Markdown

jaredlundell commented Oct 19, 2023

Looks like that help info in the console is incorrect. Here's a screenshot from the console of an Internal, Dualstack NLB, so it's definitely possible:

image

@lpizzinidev
Copy link
Copy Markdown
Contributor Author

lpizzinidev commented Oct 20, 2023

@jaredlundell
👍 I'll adapt the implementation, thanks!

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 22, 2023

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

sumupitchayan
sumupitchayan previously approved these changes Dec 20, 2023
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 20, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed sumupitchayan’s stale review December 20, 2023 16:26

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 20, 2023
@sumupitchayan
Copy link
Copy Markdown
Contributor

sumupitchayan commented Dec 22, 2023

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 22, 2023

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@kaizencc kaizencc changed the title feat(elasticloadbalancingv2): support dualstack NetworkLoadBalancer feat(elasticloadbalancingv2): dualstack NetworkLoadBalancer Dec 22, 2023
kaizencc
kaizencc previously approved these changes Dec 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was previously approved

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 22, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed kaizencc’s stale review December 23, 2023 21:39

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 24, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fea2a3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e03a41f into aws:main Dec 24, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
@lpizzinidev @paulhcsun
feat(elasticloadbalancingv2): dualstack NetworkLoadBalancer (aws#27546)
88028ba 
Adds support for dual-stack NetworkLoadBalancer via the [`ipAddressType`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-loadbalancer.html#cfn-elasticloadbalancingv2-loadbalancer-ipaddresstype) property.

Example:
```
const lb = new elbv2.NetworkLoadBalancer(this, 'LB', {
  vpc,
  internetFacing: true
  ipAddressType: elbv2.IpAddressType.DUAL_STACK,
});
```

Also, added validation to enforce that UDP or TCP_UDP listeners cannot be added to a dualstack NLB.

Closes aws#27538.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaizencc kaizencc kaizencc approved these changes

+2 more reviewers

@laurelmay laurelmay laurelmay approved these changes

@sumupitchayan sumupitchayan sumupitchayan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ElasticLoadBalancingV2: add dualstack NetworkLoadBalancer creation

6 participants

@lpizzinidev @jaredlundell @aws-cdk-automation @sumupitchayan @laurelmay @kaizencc