Skip to content

fix(sample-app): exclude all __pycache__ in cdk.json#27191

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
n0061q:main
Sep 19, 2023
Merged

fix(sample-app): exclude all __pycache__ in cdk.json#27191
mergify[bot] merged 2 commits intoaws:mainfrom
n0061q:main

Conversation

@n0061q
Copy link
Copy Markdown
Contributor

@n0061q n0061q commented Sep 19, 2023

Following the cdk workshop for python I noticed that cdk watch watches files from __pycache__.

This is an attempt to fix that.

Steps to reproduce:

  1. cdk init sample-app --language python
  2. cdk bootstrap
  3. Run cdk watch and notice that __pycache__ folders are being watched:
'watch' is observing directory 'cdk_workshop/__pycache__' for changes
'watch' is observing the file 'cdk_workshop/cdk_workshop_stack.py' for changes
'watch' is observing the file 'cdk_workshop/__pycache__/__init__.cpython-311.pyc' for changes
'watch' is observing the file 'cdk_workshop/__pycache__/cdk_workshop_stack.cpython-311.pyc' for changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Sep 19, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 19, 2023 10:05
@github-actions github-actions bot added the p2 label Sep 19, 2023
@n0061q n0061q temporarily deployed to test-pipeline September 19, 2023 10:06 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain changed the title fix(sample-app): properly exclude __pycache__ in cdk.json fix(sample-app): exclude all __pycache__ in cdk.json Sep 19, 2023
@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 19, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 19, 2023 10:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6a627a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d9f1f09 into aws:main Sep 19, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

HBobertz pushed a commit that referenced this pull request Sep 19, 2023
Following the cdk workshop for python I noticed that `cdk watch` watches files from `__pycache__`.

This is an attempt to fix that.

Steps to reproduce:
1. `cdk init sample-app --language python`
2. `cdk bootstrap`
3. Run `cdk watch` and  notice that `__pycache__` folders are being watched:
```
'watch' is observing directory 'cdk_workshop/__pycache__' for changes
'watch' is observing the file 'cdk_workshop/cdk_workshop_stack.py' for changes
'watch' is observing the file 'cdk_workshop/__pycache__/__init__.cpython-311.pyc' for changes
'watch' is observing the file 'cdk_workshop/__pycache__/cdk_workshop_stack.cpython-311.pyc' for changes
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants