Skip to content

chore(integ-tests): Applying type coercion to byte array when necessary#27092

Merged
mergify[bot] merged 2 commits intomainfrom
otaviom/integ-tests-type-coercion
Sep 11, 2023
Merged

chore(integ-tests): Applying type coercion to byte array when necessary#27092
mergify[bot] merged 2 commits intomainfrom
otaviom/integ-tests-type-coercion

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

#27009 introduced support for Uint8Array if users want to send data with the same types as those declared in the SDK v3 API. But existing tests, that use strings, will break.

Apply type coercion when necessary.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2023 10:27
@github-actions github-actions bot added the p2 label Sep 11, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1b2bd2e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 57585c7 into main Sep 11, 2023
@mergify mergify bot deleted the otaviom/integ-tests-type-coercion branch September 11, 2023 11:40
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
…ry (#27092)

#27009 introduced support for `Uint8Array` if users want to send data with the same types as those declared in the SDK v3 API. But existing tests, that use strings, will break.

Apply type coercion when necessary.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants