Skip to content

chore: update SDKv3 blob types model#27043

Merged
mergify[bot] merged 5 commits intomainfrom
huijbers/blob-types-record
Sep 7, 2023
Merged

chore: update SDKv3 blob types model#27043
mergify[bot] merged 5 commits intomainfrom
huijbers/blob-types-record

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Sep 7, 2023

Add a script that will automatically extract the blob parameter type data from the AWS SDKv3.

scripts/update-sdkv3-blobs-model.sh will download the files and drive scripts/update-sdkv3-blobs-model.ts, which does the actual collection.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a script that will automatically extract the blob parameter type data from
the AWS SDKv3.
@rix0rrr rix0rrr requested a review from a team September 7, 2023 12:00
@github-actions github-actions bot added the p2 label Sep 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 7, 2023 12:00
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 7, 2023
@@ -0,0 +1,561 @@
// This file was generated from the aws-sdk-js-v3 at Thu Sep 07 2023 13:59:10 GMT+0200 (Central European Summer Time)
export interface BlobTypeMapping {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export interface BlobTypeMapping {
export interface TypeCoercionMap {

[action: string]: string[]
}
};
export const blobTypes: BlobTypeMapping = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const blobTypes: BlobTypeMapping = {
export const UINT8ARRAY_PARAMETERS: TypeCoercionMap = {

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 7, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 36cc054
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c0a46e6 into main Sep 7, 2023
@mergify mergify bot deleted the huijbers/blob-types-record branch September 7, 2023 15:46
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
Add a script that will automatically extract the blob parameter type data from the AWS SDKv3.

`scripts/update-sdkv3-blobs-model.sh` will download the files and drive `scripts/update-sdkv3-blobs-model.ts`, which does the actual collection.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants