Skip to content

fix(eks): use Python 3.10 runtime for kubectl-provider#27031

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
plumdog:issue-26994-eks-newer-python-runtime
Sep 19, 2023
Merged

fix(eks): use Python 3.10 runtime for kubectl-provider#27031
mergify[bot] merged 6 commits intoaws:mainfrom
plumdog:issue-26994-eks-newer-python-runtime

Conversation

@plumdog
Copy link
Copy Markdown
Contributor

@plumdog plumdog commented Sep 6, 2023 •
edited by mrgrain
Loading

Use Python 3.10 runtime for kubectl-provider. The previously used version is now EOL and will be deprecated soon in AWS Lambda.

Note that while newer Python runtime versions are already available, 3.10 is the newest runtime available in all partitions (including GovCloud and CN).

Closes #26994.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Sep 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 6, 2023 12:43
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Sep 6, 2023
plumdog
plumdog commented Sep 6, 2023
View reviewed changes
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@plumdog
Copy link
Copy Markdown
Contributor Author

plumdog commented Sep 6, 2023

Clarification Request

  • Maybe this is not a feature? Regardless, I don't think it warrants a change to the README.
  • It doesn't appear that the unit tests check for this
  • I'm unable to run the integration tests.

@plumdog plumdog force-pushed the issue-26994-eks-newer-python-runtime branch from 744eb51 to 747e3ad Compare September 6, 2023 14:14
@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Sep 6, 2023
@plumdog plumdog force-pushed the issue-26994-eks-newer-python-runtime branch from 747e3ad to 9034c68 Compare September 6, 2023 14:15
@plumdog
Copy link
Copy Markdown
Contributor Author

plumdog commented Sep 18, 2023

I lieu of running the integration tests, I have modified a kubectl provider Lambda deployed by CDK and found that it was able to run and upgrade a helm chart for me, so I am confident it works.

@plumdog plumdog changed the title feat(eks): newer Python runtime for kubectl-provider feat(aws-eks): newer Python runtime for kubectl-provider Sep 18, 2023
@plumdog plumdog changed the title feat(aws-eks): newer Python runtime for kubectl-provider feat(eks): newer Python runtime for kubectl-provider Sep 18, 2023
@plumdog
Copy link
Copy Markdown
Contributor Author

plumdog commented Sep 18, 2023

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 18, 2023
@pahud pahud mentioned this pull request Sep 18, 2023
Closed
2 tasks
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Sep 18, 2023

Thanks @plumdog I'll pick this up soon. Apologies for the delay. We were operating with reduced capacity the last couple weeks.

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Sep 19, 2023
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Sep 19, 2023

Is Python 3.11 the right runtime? I couldn't find anything confirming which Lambda runtimes are available in which regions. The blog post https://aws.amazon.com/about-aws/whats-new/2023/07/aws-lambda-python-3-11/ says "The Python 3.11 runtime is available in all Regions where Lambda is available, except for China and GovCloud Regions." which was published 27th July 2023.

We have to use Python 3.10 for now. Once Python 3.11 is cleared for the remaining regions, we can switch over.

I have not run the integration tests because - based on https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#integration-tests - I understand doing so will attempt to deploy some AWS resources. I don't know what the billing implications of this would be, but I don't have an AWS account where I'm happy to chance this.

I can do this.

@mrgrain mrgrain changed the title feat(eks): newer Python runtime for kubectl-provider feat(eks): use Python 3.10 runtime for kubectl-provider Sep 19, 2023
@mrgrain mrgrain changed the title feat(eks): use Python 3.10 runtime for kubectl-provider fix(eks): use Python 3.10 runtime for kubectl-provider Sep 19, 2023
@mrgrain mrgrain added the pr-linter/exempt-test The PR linter will not require test changes label Sep 19, 2023
mrgrain
mrgrain previously approved these changes Sep 19, 2023
View reviewed changes
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 19, 2023 15:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation
aws-cdk-automation previously requested changes Sep 19, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Sep 19, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 19, 2023 17:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed mrgrain’s stale review September 19, 2023 17:28

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 19, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7e2be90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 55859c9 into aws:main Sep 19, 2023
HBobertz pushed a commit that referenced this pull request Sep 19, 2023
@plumdog
fix(eks): use Python 3.10 runtime for kubectl-provider (#27031)
f551185 
Use Python 3.10 runtime for kubectl-provider. The previously used version is now EOL and will be deprecated soon in AWS Lambda.

Note that while newer Python runtime versions are already available, 3.10 is the newest runtime available in all partitions (including GovCloud and CN).

Closes #26994.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Oct 1, 2023
Closed
@plumdog plumdog deleted the issue-26994-eks-newer-python-runtime branch April 23, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr/needs-cli-test-run This PR needs CLI tests run against it. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-eks: do not use Python 3.7 Lambda runtime for the kubectl provider

3 participants

@plumdog @mrgrain @aws-cdk-automation