Skip to content

feat(cloudwatch): add verticalAnnotations property to GraphWidget#26819

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
jasonsaruulo:main
Sep 19, 2023
Merged

feat(cloudwatch): add verticalAnnotations property to GraphWidget#26819
mergify[bot] merged 3 commits intoaws:mainfrom
jasonsaruulo:main

Conversation

@jasonsaruulo
Copy link
Copy Markdown
Contributor

Adds a verticalAnnotation property to GraphWidget, reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format

Shoutout to brendo-m for coming up with the solution

Closes #7622.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 20, 2023 20:41
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 20, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review August 20, 2023 21:16

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@jasonsaruulo jasonsaruulo force-pushed the main branch 2 times, most recently from 7d3a43d to 372fa84 Compare August 21, 2023 15:48
@jasonsaruulo
Copy link
Copy Markdown
Contributor Author

jasonsaruulo commented Aug 21, 2023

@aws-cdk/aws-lambda-python-alpha: Tests:    1 failed, 10 total
@aws-cdk/aws-lambda-python-alpha: Failed: /codebuild/output/src2667547544/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python-alpha/test/integ.function.poetry.js
@aws-cdk-testing/framework-integ:   UNCHANGED  aws-s3/test/integ.bucket-server-access-logs-sse-kms 1.373s
@aws-cdk-testing/framework-integ:   UNCHANGED  aws-s3/test/integ.bucket.domain-name 1.176s
@aws-cdk-testing/framework-integ:   UNCHANGED  aws-route53-targets/test/integ.cloudfront-alias-target 3.451s
@aws-cdk/aws-lambda-python-alpha: Error: Some tests failed!
@aws-cdk/aws-lambda-python-alpha: To re-run failed tests run: integ-runner --update-on-failed
@aws-cdk/aws-lambda-python-alpha:     at main (/codebuild/output/src2667547544/src/github.com/aws/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:190:19)
@aws-cdk/aws-lambda-python-alpha: Error: integ-runner exited with error code 1
@aws-cdk/aws-lambda-python-alpha: Tests failed. Total time (3m32.7s) | integ-runner (2m29.1s) | /codebuild/output/src2667547544/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (1m3.6s)
@aws-cdk/aws-lambda-python-alpha: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
@aws-cdk/aws-lambda-python-alpha: �[2K�[1G�[31merror�[39m Command failed with exit code 1.
@aws-cdk/aws-lambda-python-alpha: �[2K�[1G�[34minfo�[39m Visit �[1mhttps://yarnpkg.com/en/docs/cli/run�[22m for documentation about this command.
aws-cdk-lib: PASS aws-iam/test/escape-hatch.test.ts

Is this failed test related to the introduced changes? Can someone help me out here?

Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small nits about the date time specification

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@mergify mergify bot dismissed rix0rrr’s stale review September 17, 2023 21:35

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 18, 2023
mrgrain
mrgrain previously approved these changes Sep 19, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 19, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review September 19, 2023 10:06

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b5d0841
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d41005e into aws:main Sep 19, 2023
HBobertz pushed a commit that referenced this pull request Sep 19, 2023
…6819)

Adds a verticalAnnotation property to GraphWidget, reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format

Shoutout to brendo-m for coming up with the solution

Closes #7622.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Dec 13, 2023
This PR added support for start and end time of the schedule.

## Description
Currently, users cannot set a start time and an end time for the schedule.
A schedule without a start date will begin as soon as it is created and available, and without an end date, it will continue to invoke its target indefinitely.
With this feature, users can set the start and end dates of a schedule, allowing for more flexible schedule configurations.
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-startdate
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-enddate

In CloudFormation, users can use this feature as follows:
```yaml
  TestSchedule:
    Type: AWS::Scheduler::Schedule
    Properties: 
      StartDate: "2024-12-01T13:09:00.000Z"
      EndDate: "2025-12-01T00:00:00.001Z"
      ScheduleExpression: "at(2023-01-01T00:00:00)"
      State: "ENABLED"
      Target: # target
```

## Major changes
### add property to ScheduleProps interface
Added startDate and endDate properties, and typed these values as string based on the following PR comments.
#26819 (comment)

It is not necessary to specify both startDate and endDate, they can be set independently.
Validation is performed on the following points.
- Error if not following ISO 8601 format.
  - Must include milliseconds (yyyy-MM-ddTHH:mm:ss.SSSZ)
- Error if startDate is later than endDate

If a time before the current time is specified, the following error occurs in CFn, but no validation is performed because the timing of validation in CDK and the timing of actual deployment are different.
`The StartDate you specify cannot be earlier than 5 minutes ago.`

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical annotations for CloudWatch GraphWidgets

4 participants