Skip to content

chore: fix aws-lambda-nodejs test flakiness#26448

Merged
mergify[bot] merged 5 commits intomainfrom
mrgrain/chore/fake-filesystem-for-nodejs-tests
Jul 20, 2023
Merged

chore: fix aws-lambda-nodejs test flakiness#26448
mergify[bot] merged 5 commits intomainfrom
mrgrain/chore/fake-filesystem-for-nodejs-tests

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Jul 20, 2023

Uses a fake file system in aws-lambda-nodejs tests to avoid intermittent test failures when attempting to access the real file system.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 20, 2023 14:06
@github-actions github-actions bot added the p2 label Jul 20, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 20, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 20, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aa2653a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 64e4f41 into main Jul 20, 2023
@mergify mergify bot deleted the mrgrain/chore/fake-filesystem-for-nodejs-tests branch July 20, 2023 16:59
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
Uses a fake file system in `aws-lambda-nodejs` tests to avoid intermittent test failures when attempting to access the real file system.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants