feat(neptune-alpha): support for Neptune serverless#26445
Merged
mergify[bot] merged 5 commits intoaws:mainfrom Jul 25, 2023
Merged
feat(neptune-alpha): support for Neptune serverless#26445mergify[bot] merged 5 commits intoaws:mainfrom
mergify[bot] merged 5 commits intoaws:mainfrom
Conversation
jumic
approved these changes
Jul 24, 2023
Contributor
jumic
left a comment
There was a problem hiding this comment.
From my perspective (as a community reviewer) this looks good. Thanks.
kaizencc
previously requested changes
Jul 24, 2023
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Thanks @lpizzinidev and @jumic! My only comment is that wherever possible, I'd like to return the actual values received in the error messages
| throw new Error('ServerlessScalingConfiguration minCapacity must be greater or equal than 1'); | ||
| } | ||
| if (serverlessScalingConfiguration.maxCapacity < 2.5 || serverlessScalingConfiguration.maxCapacity > 128) { | ||
| throw new Error('ServerlessScalingConfiguration maxCapacity must be between 2.5 and 128'); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new Error('ServerlessScalingConfiguration maxCapacity must be between 2.5 and 128'); | |
| throw new Error(`ServerlessScalingConfiguration maxCapacity must be between 2.5 and 128, received ${serverlessScalingConfiguration.maxCapacity}`); |
| throw new Error('ServerlessScalingConfiguration maxCapacity must be between 2.5 and 128'); | ||
| } | ||
| if (serverlessScalingConfiguration.minCapacity >= serverlessScalingConfiguration.maxCapacity) { | ||
| throw new Error('ServerlessScalingConfiguration minCapacity must be less than serverlessScalingConfiguration maxCapacity'); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new Error('ServerlessScalingConfiguration minCapacity must be less than serverlessScalingConfiguration maxCapacity'); | |
| throw new Error(`ServerlessScalingConfiguration minCapacity (${serverlessScalingConfiguration.minCapacity)}) must be less than serverlessScalingConfiguration maxCapacity (${serverlessScalingConfiguration.maxCapacity})`); |
kaizencc
approved these changes
Jul 25, 2023
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Thanks! This got in extremely smoothly :).
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
Adds support for [Neptune serverless](https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-using.html). Example of how to launch a Neptune serverless cluster: ``` new DatabaseCluster(stack, 'Database', { vpc, instanceType: InstanceType.SERVERLESS, clusterParameterGroup, removalPolicy: cdk.RemovalPolicy.DESTROY, serverlessScalingConfiguration: { minCapacity: 1, maxCapacity: 5, }, }); ``` Closes aws#26428 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Neptune serverless.
Example of how to launch a Neptune serverless cluster:
Closes #26428
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license