fix(lambda): bundling fails with pnpm >= 8.4.0 (#25612)#26386
Merged
mergify[bot] merged 1 commit intoaws:mainfrom Jul 17, 2023
Merged
fix(lambda): bundling fails with pnpm >= 8.4.0 (#25612)#26386mergify[bot] merged 1 commit intoaws:mainfrom
mergify[bot] merged 1 commit intoaws:mainfrom
Conversation
…n’t exist (aws#25612) Added -f flag when removing node_modules/.modules.yaml from output dir as part of ES Build bundling step to support both pnpm 8.3.1 and below behaviour where this file is always generated and 8.4.0 and above where this file is not generated if no node_modules exist. Signed-off-by: Damien Hill <damien@damienhill.com>
aws-cdk-automation
previously requested changes
Jul 17, 2023
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
approved these changes
Jul 17, 2023
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
colifran
pushed a commit
that referenced
this pull request
Jul 17, 2023
Fix issue with esbuild bundling step using pnpm 8.4.0 and above where `{outputDir}/node_modules/.modules.yaml` does not always exist and current `rm` command fails bundling process when file is not present.
Relevant change that in [pnpm 8.4.0 release notes](https://github.com/pnpm/pnpm/releases/tag/v8.4.0):
> Do not create a node_modules folder with a .modules.yaml file if there are no dependencies inside node_modules.
Solved by following prior rejected pull request #25617 and suggestion in original issue #25612 of adding `-f` param to `rm` command to succeed even if file doesn't exist. Updated relevant unit test to expect this flag when using pnpm.
Closes #25612.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
Fix issue with esbuild bundling step using pnpm 8.4.0 and above where `{outputDir}/node_modules/.modules.yaml` does not always exist and current `rm` command fails bundling process when file is not present.
Relevant change that in [pnpm 8.4.0 release notes](https://github.com/pnpm/pnpm/releases/tag/v8.4.0):
> Do not create a node_modules folder with a .modules.yaml file if there are no dependencies inside node_modules.
Solved by following prior rejected pull request aws#25617 and suggestion in original issue aws#25612 of adding `-f` param to `rm` command to succeed even if file doesn't exist. Updated relevant unit test to expect this flag when using pnpm.
Closes aws#25612.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with esbuild bundling step using pnpm 8.4.0 and above where
{outputDir}/node_modules/.modules.yamldoes not always exist and currentrmcommand fails bundling process when file is not present.Relevant change that in pnpm 8.4.0 release notes:
Solved by following prior rejected pull request #25617 and suggestion in original issue #25612 of adding
-fparam tormcommand to succeed even if file doesn't exist. Updated relevant unit test to expect this flag when using pnpm.Closes #25612.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license