Skip to content

fix(stepfunctions-tasks): specify tags in BatchSubmitJob properties#26349

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
lpizzinidev:gh-26336
Jul 25, 2023
Merged

fix(stepfunctions-tasks): specify tags in BatchSubmitJob properties#26349
mergify[bot] merged 4 commits intoaws:mainfrom
lpizzinidev:gh-26336

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

This change adds the possibility to specify the tags property in the BatchSubmitJob construct.

Closes #26336.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 13, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 13, 2023 14:34
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jul 13, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 13, 2023
Copy link
Copy Markdown
Contributor

@daschaa daschaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I only left one comment regarding the docstring for a function.

}

/**
* Validate the specified tags according to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function is very well written and self explanatory. Do we really need the docstring? What happens if the URL will change in the future?

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 25, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e464650
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f24ece1 into aws:main Jul 25, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
…ws#26349)

This change adds the possibility to specify the [`tags`](https://docs.aws.amazon.com/batch/latest/APIReference/API_SubmitJob.html#:~:text=Required%3A%20No-,tags,-The%20tags%20that) property in the `BatchSubmitJob` construct.

Closes aws#26336.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-stepfunctions-tasks: Tag Batch Jobs

4 participants