chore(custom-resource-handlers): refactor minify and bundling step#26287
Merged
mergify[bot] merged 1 commit intomainfrom Jul 7, 2023
Merged
chore(custom-resource-handlers): refactor minify and bundling step#26287mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
|
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Jul 7, 2023
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
tmokmss
pushed a commit
to tmokmss/aws-cdk
that referenced
this pull request
Jul 9, 2023
…ws#26287) Make `minify-and-bundle-sources.ts` more clear by putting the bundled files into its own `dist` folder, and copying that `dist` folder into `aws-cdk-lib`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
In this [PR](#26287), we moved the custom resource handlers from the `lib` directory to `dist` - but any `dist` directory is npm ignored. This is causing failures in our pipeline when running cli integration tests: ```console Error: cannot find /tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/custom-resource-handlers/dist/aws-s3/auto-delete-objects-handler/index.js -- 242 | at new CustomResourceProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:3214) 243 | at Function.getOrCreateProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:2660) 244 | at Bucket.enableAutoDeleteObjects (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:32627) 245 | at new Bucket (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:21317) 246 | at new BuiltinLambdaStack (/tmp/cdk-integ-0u3tmsd7dnl/app.js:379:5) 247 | at Object.<anonymous> (/tmp/cdk-integ-0u3tmsd7dnl/app.js:449:5) 248 | at Module._compile (node:internal/modules/cjs/loader:1196:14) 249 | at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10) 250 | at Module.load (node:internal/modules/cjs/loader:1074:32) ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
colifran
pushed a commit
that referenced
this pull request
Jul 17, 2023
In this [PR](#26287), we moved the custom resource handlers from the `lib` directory to `dist` - but any `dist` directory is npm ignored. This is causing failures in our pipeline when running cli integration tests: ```console Error: cannot find /tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/custom-resource-handlers/dist/aws-s3/auto-delete-objects-handler/index.js -- 242 | at new CustomResourceProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:3214) 243 | at Function.getOrCreateProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:2660) 244 | at Bucket.enableAutoDeleteObjects (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:32627) 245 | at new Bucket (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:21317) 246 | at new BuiltinLambdaStack (/tmp/cdk-integ-0u3tmsd7dnl/app.js:379:5) 247 | at Object.<anonymous> (/tmp/cdk-integ-0u3tmsd7dnl/app.js:449:5) 248 | at Module._compile (node:internal/modules/cjs/loader:1196:14) 249 | at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10) 250 | at Module.load (node:internal/modules/cjs/loader:1074:32) ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
…ws#26287) Make `minify-and-bundle-sources.ts` more clear by putting the bundled files into its own `dist` folder, and copying that `dist` folder into `aws-cdk-lib`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
In this [PR](aws#26287), we moved the custom resource handlers from the `lib` directory to `dist` - but any `dist` directory is npm ignored. This is causing failures in our pipeline when running cli integration tests: ```console Error: cannot find /tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/custom-resource-handlers/dist/aws-s3/auto-delete-objects-handler/index.js -- 242 | at new CustomResourceProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:3214) 243 | at Function.getOrCreateProvider (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/core/lib/custom-resource-provider/custom-resource-provider.js:1:2660) 244 | at Bucket.enableAutoDeleteObjects (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:32627) 245 | at new Bucket (/tmp/cdk-integ-0u3tmsd7dnl/node_modules/aws-cdk-lib/aws-s3/lib/bucket.js:1:21317) 246 | at new BuiltinLambdaStack (/tmp/cdk-integ-0u3tmsd7dnl/app.js:379:5) 247 | at Object.<anonymous> (/tmp/cdk-integ-0u3tmsd7dnl/app.js:449:5) 248 | at Module._compile (node:internal/modules/cjs/loader:1196:14) 249 | at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10) 250 | at Module.load (node:internal/modules/cjs/loader:1074:32) ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
minify-and-bundle-sources.tsmore clear by putting the bundled files into its owndistfolder, and copying thatdistfolder intoaws-cdk-lib.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license