Skip to content

fix(cli): specifying --quiet does not suppress asset building and publishing logs#26265

Closed
fwang wants to merge 1 commit intoaws:mainfrom
anomalyco:asset-publish-quite
Closed

fix(cli): specifying --quiet does not suppress asset building and publishing logs#26265
fwang wants to merge 1 commit intoaws:mainfrom
anomalyco:asset-publish-quite

Conversation

@fwang
Copy link
Copy Markdown

@fwang fwang commented Jul 6, 2023

We're currently maintaining a patched version of CDK to use with SST because this flag isn't fully respected. When the quiet flag is specified, the docker build and docker push shell commands still print to the terminal. This PR propagates the quiet flag down to the cdk-assets's container-images handler.

Would appreciate this functionality - would greatly simplify things on our end

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 6, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 6, 2023 17:13
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 6, 2023
aws-cdk-automation
aws-cdk-automation requested changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 6, 2023
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 6, 2023

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/26265/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 6, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f7ef343
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 6, 2023

Looks good! Can you sort out the build failure and add/extend a test to cover this new use case?

There's an existing test but I'm not even sure it does test --quiet properly. 🙈

aws-cdk/packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts

Line 725 in a523e9f

integTest('synth --quiet can be specified in cdk.json', withDefaultFixture(async (fixture) => {

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 18, 2023

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 18, 2023

update

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@serverless-stack needs to authorize modification on its head branch.
err-code: EF018

@mrgrain mrgrain mentioned this pull request Jul 25, 2023
Merged
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 28, 2023

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@mrgrain mrgrain closed this Jul 28, 2023
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Jul 28, 2023

Closed in favor of #26493

@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
mergify bot pushed a commit that referenced this pull request Aug 3, 2023
@mrgrain
fix(cli): specifying --quiet does not suppress asset building and pub…
b12bc67 
…lishing logs (#26493)

> We're currently maintaining a patched version of CDK to use with [SST](https://docs.sst.dev/) because this flag isn't fully respected. When the quiet flag is specified, the docker build and docker push shell commands still print to the terminal. This PR propagates the quiet flag down to the cdk-assets's container-images handler.

Replaces #26265

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-cli-test-run This PR needs CLI tests run against it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fwang @aws-cdk-automation @mrgrain