chore(ec2): replace latestAmazonLinux with latestAmazonLinux2 used inside BastionHostLinux #26134
chore(ec2): replace latestAmazonLinux with latestAmazonLinux2 used inside BastionHostLinux #26134mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
|
|
corymhall
left a comment
There was a problem hiding this comment.
@clueleaf thanks for creating this PR! It looks like changing the machine image results in a breaking change (the instance will be replaced) so this will have to be behind a feature flag.
If you are up for that then we should also make machineImage a required property and not default it for the user. Since we can't make it required from a type perspective we'll have to do it with a check inside the construct.
|
@corymhall aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/bastion-host.ts Lines 66 to 67 in 048d579 |
corymhall
left a comment
There was a problem hiding this comment.
I'm not sure if we should call this a breaking change, because the document is already clarifying that the instance may be replaced on every deployment when we do not specify a machineImage.
Good point!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@corymhall hi, will this PR get merged? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…side BastionHostLinux (aws#26134) Synthesizing `BastionHostLinux` generates the following warning: ``` [WARNING] aws-cdk-lib.aws_ec2.MachineImage#latestAmazonLinux is deprecated. use MachineImage.latestAmazonLinux2 instead This API will be removed in the next major release. ``` This PR replaces `latestAmazonLinux` used inside `BastionHostLinux` with `latestAmazonLinux2` to remove the warning. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Synthesizing
BastionHostLinuxgenerates the following warning:This PR replaces
latestAmazonLinuxused insideBastionHostLinuxwithlatestAmazonLinux2to remove the warning.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license