feat(core): Support cache-from and cache-to flags in DockerImage#25925
feat(core): Support cache-from and cache-to flags in DockerImage#25925
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
TS syntax error preventing build. Closing again. @alukach Feel free to open a new PR that fixes the issues |
In #24024, we added the ability to specify Docker cache flags during ecr-asset builds. However, it was not added to the `DockerImage` class. This PR adds the ability to specify the `--cache-from` and `--cache-to` flag to `DockerImage` builds. This logic was primarily lifted directly from #24024. Fixup of issues from #25925 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
In #24024, we added the ability to specify Docker cache flags during ecr-asset builds. However, it was not added to the
DockerImageclass. This PR adds the ability to specify the--cache-fromand--cache-toflag toDockerImagebuilds.This logic was primarily lifted directly from #24024.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license