fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy#25920
fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy#25920mergify[bot] merged 6 commits intoaws:mainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
This comment was marked as outdated.
This comment was marked as outdated.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Added integration test. I withdraw my exemption request. |
Pull request has been modified.
|
@otaviomacedo Thanks for review! I added a test. |
…y when using Token (#25922) Related to #25920. In `AutoScalingGroup`, `maxCapacity` defaults to `Math.max(minCapacity, 1)` even when `minCapacity` is a Token. Because Token number is always negative number, `maxCapacity` will be set to `1` when `maxCapacity` is `undefined` and `minCapacity` is a Token. see also #25795 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #25795.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license