feat(core): add option to suppress indentation in templates#25892
feat(core): add option to suppress indentation in templates#25892mergify[bot] merged 5 commits intoaws:mainfrom jesterhazy:je/indent
Conversation
|
|
|
note: integration tests have NOT been run |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request: this change doesn't seem to warrant an integration test. |
|
Clarification Request: which readme file would you expect to be updated for this? |
corymhall
left a comment
There was a problem hiding this comment.
@jesterhazy thanks for taking the time to create this PR! Looking at the pasted issues on this I think we should try to solve this differently. I want to solve this 1 time, what is the absolute best we can do in regards to template size and how can we do it automatically.
We can either use the linked issue to discuss the potential solutions or you can create a new issue to discuss, I'll leave it up to you.
corymhall
left a comment
There was a problem hiding this comment.
@jesterhazy actually after looking into this more I think you are on the right track. It looks like this is the best that we can do (for some reason I was thinking there was still something more we could do).
I only have 2 minor comments and then I'm good with this.
|
@corymhall what needs to happen to move this forward? |
corymhall
left a comment
There was a problem hiding this comment.
Can you also add a simple integration test (or update an existing one) that sets the suppressTemplateIndentations: true. I just want to have a test that actually deploys a template without indentation.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
several of the tests in |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This change extends aws#25892 (which added indentation suppression to `Stack`) to also support `NestedStack`. It relies on the existing behavior in `Stack` and the same `suppressTemplateIndentation` property.
Fixes #18694, #8712
This change adds an option to suppress indentation in CloudFormation template files. Suppressing indentation will reduce the file size of templates.
Indentation can be set by enabling for specific Stacks using the new
suppressTemplateIndentationproperty inStackProps, or globally using the new@aws-cdk/core:suppressTemplateIndentationcontext key.This PR provides additional template size reduction beyond the indentation change in #19656.
@rix0rrr @mackalex @PatMyron
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license