Skip to content

chore(core): Revert #24443 add stage prefix to stack name shortening process#25163

Merged
mergify[bot] merged 1 commit intomainfrom
revert-24443-QustodioPablo/fix-stack-name-too-long
Apr 17, 2023
Merged

chore(core): Revert #24443 add stage prefix to stack name shortening process#25163
mergify[bot] merged 1 commit intomainfrom
revert-24443-QustodioPablo/fix-stack-name-too-long

Conversation

@kellertk
Copy link
Copy Markdown
Member

@kellertk kellertk commented Apr 17, 2023

Reverts #24443.

Fixes #25130.

@aws-cdk-automation aws-cdk-automation requested a review from a team April 17, 2023 23:21
@github-actions github-actions bot added the p2 label Apr 17, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 17, 2023
@kellertk kellertk added p0 and removed p2 labels Apr 17, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@comcalvi comcalvi changed the title fix(core)!: Revert #24443 add stage prefix to stack name shortening process chore(core): Revert #24443 add stage prefix to stack name shortening process Apr 17, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 17, 2023 23:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 17, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e0b8f00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8492dfe into main Apr 17, 2023
@mergify mergify bot deleted the revert-24443-QustodioPablo/fix-stack-name-too-long branch April 17, 2023 23:44
comcalvi pushed a commit that referenced this pull request Apr 18, 2023
@kellertk @comcalvi
chore(core): Revert #24443 add stage prefix to stack name shortening …
cfac3f3 
…process (#25163)

Reverts #24443.

Fixes #25130.
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@comcalvi comcalvi comcalvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@comcalvi comcalvi

Labels

contribution/core This is a PR that came from AWS. p0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-cdk-lib: Stack names broken after prefix changes on 2.74.0 version

3 participants

@kellertk @aws-cdk-automation @comcalvi