Skip to content

feat(ec2): added ulimits property to ContainerDefinitionOptions#24963

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
lpizzinidev:gh-24918
Apr 6, 2023
Merged

feat(ec2): added ulimits property to ContainerDefinitionOptions#24963
mergify[bot] merged 2 commits intoaws:mainfrom
lpizzinidev:gh-24918

Conversation

@lpizzinidev
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev commented Apr 6, 2023

This adds the ulimits property to ContainerDefinitionOptions, allowing to specify the parameter in the addContainer method:

const task = ecs.TaskDefinition(...);
task.addContainer('id', {
    ...,
    ulimits: [{
        hardLimit: 128,
        name: ecs.UlimitName.RSS,
        softLimit: 128,
     }],
});

Closes #24918.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 6, 2023 07:43
@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Apr 6, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Apr 6, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8fe721c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e37d16a into aws:main Apr 6, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tam0ri tam0ri mentioned this pull request Jun 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 30, 2023
@tam0ri
chore(ecs): remove unnecessary js and d.ts files for integration test (…
7036c27 
…#26030)

From #24963, unnecessary js and d.ts files which had been built for integration test were pushed. This PR removes these files.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set ulimit in container definition prop

3 participants

@lpizzinidev @aws-cdk-automation @otaviomacedo