Skip to content

fix(ecr-assets): prefix cache arguments correctly#24524

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
RichiCoder1:fix-ecr-cache-args
Mar 8, 2023
Merged

fix(ecr-assets): prefix cache arguments correctly#24524
mergify[bot] merged 1 commit intoaws:mainfrom
RichiCoder1:fix-ecr-cache-args

Conversation

@RichiCoder1
Copy link
Copy Markdown
Contributor

Follow up to #24024, fixes an issue where cache args were not correctly prefixed and adds additional testing.

Apologies for the second PR, I realized there was an issue literally as the auto-merge happened!


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Mar 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 8, 2023 20:24
@github-actions github-actions bot added the p2 label Mar 8, 2023
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@RichiCoder1
Copy link
Copy Markdown
Contributor Author

Exemption Request: bug fix that has no integration changes/outputs

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 8, 2023
@RichiCoder1 RichiCoder1 changed the title fix: prefix cache arguments correctly fix(ecr-assets): prefix cache arguments correctly Mar 8, 2023
@MrArnoldPalmer MrArnoldPalmer added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 8, 2023
Copy link
Copy Markdown
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good catch @RichiCoder1 ! TY for the fix.

@aws-cdk-automation aws-cdk-automation dismissed their stale review March 8, 2023 20:49

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ec1bdd9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d451b30 into aws:main Mar 8, 2023
@RichiCoder1 RichiCoder1 deleted the fix-ecr-cache-args branch March 8, 2023 21:04
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
Follow up to aws#24024, fixes an issue where cache args were not correctly prefixed and adds additional testing.

Apologies for the second PR, I realized there was an issue literally as the auto-merge happened!

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants