Skip to content

fix: Correct SamlConsolePrincipal for non-China#24277

Merged
mergify[bot] merged 3 commits intomainfrom
24243
Feb 22, 2023
Merged

fix: Correct SamlConsolePrincipal for non-China#24277
mergify[bot] merged 3 commits intomainfrom
24243

Conversation

@Naumel
Copy link
Copy Markdown
Contributor

@Naumel Naumel commented Feb 22, 2023

Closes #24243.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 22, 2023

@github-actions github-actions bot added the p2 label Feb 22, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2023 18:02
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p0 and removed p2 labels Feb 22, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 22, 2023
@Naumel Naumel marked this pull request as ready for review February 22, 2023 18:02
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Naumel Naumel changed the title (fix): Correct SamlConsolePrincipal for non-China fix: Correct SamlConsolePrincipal for non-China Feb 22, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 22, 2023 18:11

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e47646c into main Feb 22, 2023
@mergify mergify bot deleted the 24243 branch February 22, 2023 19:43
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7d24e35
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Naumel added a commit that referenced this pull request Feb 22, 2023
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Naumel added a commit that referenced this pull request Feb 22, 2023
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Naumel added a commit that referenced this pull request Feb 22, 2023
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Naumel added a commit that referenced this pull request Feb 23, 2023
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Naumel added a commit that referenced this pull request Feb 24, 2023
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 13, 2023
Closes aws#24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
Closes aws#24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
Closes aws#24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iam: SamlConsolePrincipal does not work in aws.amazon.com-regions

3 participants