fix(cdk-assets): Error when building Docker Image Assets with Podman#24003
fix(cdk-assets): Error when building Docker Image Assets with Podman#24003mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
|
|
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
|
@aws-cdk-automation This package doesn't appear to have any integration tests. I added unit tests as per this comment cc @madeline-k. |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
@aws-cdk-automation I'm not certain it requires the integration tests, if someone could confirm I'm happy to dig into it. Could anyone confirm? |
I think this is mostly covered by the unit test that you've added. Adding an integ test here would require contributors to have podman installed to correctly deploy the stack which feels like something we don't want to do. Gonna add the exemption here. |
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ws#24003) Encountering the same error as aws#16209 (comment). When using `podman inspect` to check whether or not an image exists, the exit code for when an image does not exist is `125`, while Docker's is `1`. This change will treat either of these exit codes as meaning that the image with the given tag does not currently exist. Closes aws#16209 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Encountering the same error as #16209 (comment). When using
podman inspectto check whether or not an image exists, the exit code for when an image does not exist is125, while Docker's is1. This change will treat either of these exit codes as meaning that the image with the given tag does not currently exist.Closes #16209
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license