Skip to content

chore: remove lingering @aws-cdk-containers file#23477

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
laurelmay:remove-aws-cdk-containers
Dec 28, 2022
Merged

chore: remove lingering @aws-cdk-containers file#23477
mergify[bot] merged 2 commits intoaws:mainfrom
laurelmay:remove-aws-cdk-containers

Conversation

@laurelmay
Copy link
Copy Markdown
Contributor

This package was removed in #21849; however, this file for some reason
remains within the repository. This was removed in that original PR, so
this is likely the result of some odd merge conflict resolution at some
point.


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This package was removed in aws#21849; however, this file for some reason
remains within the repository. This was removed in that original PR, so
this is likely the result of some odd merge conflict resolution at some
point.
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 27, 2022

@github-actions github-actions bot added the p2 label Dec 27, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team December 27, 2022 18:49
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Dec 27, 2022
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2c4e265
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 89818df into aws:main Dec 28, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Jan 20, 2023
This package was removed in aws#21849; however, this file for some reason
remains within the repository. This was removed in that original PR, so
this is likely the result of some odd merge conflict resolution at some
point.


----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho pushed a commit to brennanho/aws-cdk that referenced this pull request Feb 22, 2023
This package was removed in aws#21849; however, this file for some reason
remains within the repository. This was removed in that original PR, so
this is likely the result of some odd merge conflict resolution at some
point.


----

### All Submissions:

* [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants