feat(synthetics): lifecycle rules for auto-generated artifact buckets by mackensen · Pull Request #22863 · aws/aws-cdk

mackensen · 2022-11-10T15:09:00Z

This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth.

fixes #22634

I'm not able to run the integration tests.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…buckets This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth. fixes aws#22634

gitpod-io · 2022-11-10T15:09:06Z

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

kaizencc

Hi @mackensen! This looks good! I'll run the integ test sometime today. In the meantime, can you add this somewhere to the readme?

kaizencc · 2022-11-10T15:42:04Z

packages/@aws-cdk/aws-synthetics/lib/canary.ts

+   * Lifecycle rules for the generated canary artifact bucket.
+   *
+   * @default - No rules applied. This has no effect if a bucket is passed
+   * to `artifactsBucketLocation`.
+   */


Suggested change

* Lifecycle rules for the generated canary artifact bucket.

*

* @default - No rules applied. This has no effect if a bucket is passed

* to `artifactsBucketLocation`.

*/

* Lifecycle rules for the generated canary artifact bucket. Has no effect

* if a bucket is passed to `artifactsBucketLocation`. If you pass a bucket

* to `artifactsBucketLocation`, you can add lifecycle rules to the bucket

* itself.

*

* @default - no rules applied to the generated bucket.

*/

kaizencc · 2022-11-10T15:43:13Z

packages/@aws-cdk/aws-synthetics/test/canary.test.ts

+      handler: 'index.handler',
+      code: synthetics.Code.fromInline('/* Synthetics handler code */'),
+    }),
+    runtime: synthetics.Runtime.SYNTHETICS_1_0,


Suggested change

runtime: synthetics.Runtime.SYNTHETICS_1_0,

runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_8,

mackensen · 2022-11-10T18:07:52Z

@kaizencc thanks for the feedback, I've updated the branch.

kaizencc · 2022-11-10T20:59:51Z

@mackensen I ran the integ test for you. It is somehow here. Not sure what went on to make it not a part of this particular branch, but Ill leave it to you to merge your branch with the commit that has the updated snapshot.

In addition, this PR needs a readme update that mentions the ability to add lifecycle rules to the created s3 bucket.

mackensen · 2022-11-12T23:11:25Z

@kaizencc thanks, cherry-picked your commit and updated the README.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

aws-cdk-automation · 2022-11-12T23:47:32Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: e54e783
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kaizencc

Hi @mackensen! Apologies for not getting back to you sooner. This is ready to go once the build succeeds. My comments on the readme, when addressed, should fix the build.

kaizencc · 2022-12-02T15:03:47Z

packages/@aws-cdk/aws-synthetics/README.md

+  enforceSSL: true,
+});
+
+const canary = new synthetics.Canary(this, 'MyCanary', {


Looks like the build is failing because we are creating two canary consts in the same example.

kaizencc · 2022-12-02T15:04:21Z

packages/@aws-cdk/aws-synthetics/README.md

+
+You can pass an S3 bucket to store artifacts from canary runs. If you do not, one will be auto-generated when the canary is created. You may add [lifecycle rules](https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lifecycle-mgmt.html) to the auto-generated bucket.
+
+Artifact bucket examples:


Lets delete this line and move it in to the ts example

kaizencc · 2022-12-02T15:05:19Z

packages/@aws-cdk/aws-synthetics/README.md

+```typescript
+// Auto-generated bucket with lifecycle rules.


Suggested change

```typescript

// Auto-generated bucket with lifecycle rules.

```ts

// configure lifecycle rules on the auto-generated artifact bucket.

kaizencc · 2022-12-02T15:05:55Z

packages/@aws-cdk/aws-synthetics/README.md

+
+// Custom bucket as artifact bucket.


github ui doesn't like when my suggestions involve "```" so I'll just describe what i want here.

we should split up the example into two here and change the comment to the one below:

// configure lifecycle rules on a custom artifact bucket.

aws-cdk-automation · 2022-12-04T00:09:22Z

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation · 2022-12-11T00:09:59Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@mackensen

…#26290) A re-roll of #22863. Thanks for getting this started @mackensen! This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth. Fixes #22634 Co-authored-by: Charles Fulton fultonc@lafayette.edu ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@mackensen

…aws#26290) A re-roll of aws#22863. Thanks for getting this started @mackensen! This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth. Fixes aws#22634 Co-authored-by: Charles Fulton fultonc@lafayette.edu ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(synthetics): expose lifecycle rules for auto-generated artifact …

7d6d05a

…buckets This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth. fixes aws#22634

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 10, 2022

aws-cdk-automation requested a review from a team November 10, 2022 15:09

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 10, 2022

aws-cdk-automation previously requested changes Nov 10, 2022

View reviewed changes

kaizencc changed the title ~~feat(synthetics): expose lifecycle rules for auto-generated artifact …~~ feat(synthetics): lifecycle rules for auto-generated artifact buckets Nov 10, 2022

kaizencc requested changes Nov 10, 2022

View reviewed changes

Update inline docs

0541c25

kaizencc and others added 2 commits November 12, 2022 17:59

ran integ test

3fc5a8e

Update README

e54e783

kaizencc self-requested a review December 2, 2022 15:01

kaizencc requested changes Dec 2, 2022

View reviewed changes

aws deleted a comment from aws-cdk-automation Dec 2, 2022

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 11, 2022

aws-cdk-automation closed this Dec 11, 2022

kaizencc mentioned this pull request Jul 7, 2023

feat(synthetics): lifecycle rules for auto-generated artifact buckets #26290

Merged

-   * Lifecycle rules for the generated canary artifact bucket.
-   *
-   * @default - No rules applied. This has no effect if a bucket is passed
-   * to `artifactsBucketLocation`.
-   */
+   * Lifecycle rules for the generated canary artifact bucket. Has no effect
+   * if a bucket is passed to `artifactsBucketLocation`. If you pass a bucket
+   * to `artifactsBucketLocation`, you can add lifecycle rules to the bucket
+   * itself.
+   *
+   * @default - no rules applied to the generated bucket.
+   */

	runtime: synthetics.Runtime.SYNTHETICS_1_0,
	runtime: synthetics.Runtime.SYNTHETICS_NODEJS_PUPPETEER_3_8,


		You can pass an S3 bucket to store artifacts from canary runs. If you do not, one will be auto-generated when the canary is created. You may add [lifecycle rules](https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lifecycle-mgmt.html) to the auto-generated bucket.

		Artifact bucket examples:

Conversation

mackensen commented Nov 10, 2022 • edited by kaizencc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Adding new Unconventional Dependencies:

New Features

Uh oh!

gitpod-io bot commented Nov 10, 2022

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

kaizencc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaizencc Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

kaizencc Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

mackensen commented Nov 10, 2022

Uh oh!

kaizencc commented Nov 10, 2022

Uh oh!

mackensen commented Nov 12, 2022

Uh oh!

aws-cdk-automation commented Nov 12, 2022

AWS CodeBuild CI Report

Uh oh!

kaizencc left a comment

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

kaizencc Dec 2, 2022

Choose a reason for hiding this comment

Uh oh!

aws-cdk-automation commented Dec 4, 2022

Uh oh!

aws-cdk-automation commented Dec 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mackensen commented Nov 10, 2022 •

edited by kaizencc

Loading

kaizencc left a comment •

edited

Loading