fix(cli): assetParallelism option in cdk.json is not recognized#22781
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Nov 4, 2022
huyphan:main
Merged
fix(cli): assetParallelism option in cdk.json is not recognized#22781mergify[bot] merged 2 commits intoaws:mainfrom huyphan:main
mergify[bot] merged 2 commits intoaws:mainfrom
huyphan:main
Conversation
|
|
aws-cdk-automation
previously requested changes
Nov 4, 2022
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
Version 2.48.0 introduced a flag to enable/disable parallelism when building and publishing assets (see #22579 ). The flag is supposed to be set via either environment variable (`CDK_ASSET_PARALLELISM`), command line argument (`-[no]-asset-parallelism`), or the `cdk.json` file. However, the last method does not work. We are not passing the option from that file properly.
rix0rrr
approved these changes
Nov 4, 2022
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Naumel
pushed a commit
that referenced
this pull request
Nov 4, 2022
Version 2.48.0 introduced a flag to enable/disable parallelism when building and publishing assets (see #22579 ). The flag is supposed to be set via either environment variable (`CDK_ASSET_PARALLELISM`), command line argument (`-[no]-asset-parallelism`), or the `cdk.json` file. However, the last method does not work. We are not passing the option from that file properly. ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 2.48.0 introduced a flag to enable/disable parallelism when
building and publishing assets (see #22579 ). The flag is supposed to
be set via either environment variable (
CDK_ASSET_PARALLELISM), commandline argument (
-[no]-asset-parallelism), or thecdk.jsonfile. However,the last method does not work. We are not passing the option from that
file properly.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license