chore(prlint): add pagination to listFiles in PR#22555
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Oct 19, 2022
Merged
chore(prlint): add pagination to listFiles in PR#22555mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
|
|
4 tasks
Contributor
|
Hi, thank you for taking the time to make and submit the change. While it looks good, seems that it has side-effects:
Look at that, a merge solved it! |
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Naumel
approved these changes
Oct 19, 2022
|
|
||
| console.log(`⌛ Fetching files for PR number ${number}`); | ||
| const files = (await this.client.pulls.listFiles(this.prParams)).data; | ||
| const files = await this.client.paginate(this.client.pulls.listFiles, this.prParams); |
Contributor
There was a problem hiding this comment.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mrgrain
pushed a commit
to mrgrain/aws-cdk
that referenced
this pull request
Oct 24, 2022
Currently, the `prlint` tool lists the files on a PR to enforce new integration tests are created for `feat` changes. The tool is not using pagination for list files and is using the default of `30` files per page. This means a PR could be incorrectly flagged for missing integration tests if the test files occur after the first 30 files in the PR. Example of this can be seen in aws#22455 This PR enables pagination on the `listFiles` call to ensure the validation rules are looking at all files in the PR, not just the first 30. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
prlinttool lists the files on a PR to enforce new integration tests are created forfeatchanges. The tool is not using pagination for list files and is using the default of30files per page. This means a PR could be incorrectly flagged for missing integration tests if the test files occur after the first 30 files in the PR.Example of this can be seen in #22455
This PR enables pagination on the
listFilescall to ensure the validation rules are looking at all files in the PR, not just the first 30.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license