fix(region-info): SSM service principals are incorrect in opt-in regions#22327
Merged
mergify[bot] merged 5 commits intomainfrom Oct 4, 2022
Merged
fix(region-info): SSM service principals are incorrect in opt-in regions#22327mergify[bot] merged 5 commits intomainfrom
mergify[bot] merged 5 commits intomainfrom
Conversation
The change in #17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one.
|
|
aws-cdk-automation
previously requested changes
Oct 3, 2022
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
Pull Request updated. Dissmissing previous PRLinter Review.
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
…ons (aws#22327) The change in aws#17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
…ons (aws#22327) The change in aws#17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation".
And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal.
We therefore revert all use of SSM service principals to the global one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license