fix(integ-tests): AwsApiCall Custom Resource length could be greater than 60 characters#22119
Conversation
…than 60 characters
|
|
| salt: Date.now().toString(), | ||
| }, | ||
| resourceType: `${SDK_RESOURCE_TYPE_PREFIX}${this.name}`, | ||
| resourceType: `${SDK_RESOURCE_TYPE_PREFIX}${this.name}`.substring(0, 60), |
There was a problem hiding this comment.
| resourceType: `${SDK_RESOURCE_TYPE_PREFIX}${this.name}`.substring(0, 60), | |
| resourceType: `${SDK_RESOURCE_TYPE_PREFIX}${this.name}`.substring(0, 59), |
Add a test to be sure 🙂
There was a problem hiding this comment.
The substring method isn't inclusive for the indexEnd so it should be substring(0, 60)
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…than 60 characters (aws#22119) Limits the resource type name to 60 characters to account for CloudFormation limitations with Custom Resource Resource Types Closes aws#22055 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Limits the resource type name to 60 characters to account for CloudFormation limitations with Custom Resource Resource Types
Closes #22055
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license