Conversation
Adding the title check for all submitted PRs, not only the breaking change ones.
|
|
|
@Mergifyio update |
✅ Branch has been successfully updated |
rix0rrr
left a comment
There was a problem hiding this comment.
It's probably safer to not change the existing behavior of the breaking change checker. This specific change, requiring a module always breaks cases today where we could do chore: blabla (that is now illegal because it's not formatted like chore(something): blabla). Same for fix or feat.
Why not add a new check that PR titles conform to "conventional commits", just like the check that we used to have but are now missing?
The format should be:
<type> [ "(" <arbitrary text> ")" ] ":" <arbitrary text>
<type> := "feat" | "fix" | "chore" | "refactor" | "docs" (I think that's most of what we use)
|
From https://www.conventionalcommits.org/en/v1.0.0/#summary
|
|
This is going to conflict with the changes in #22029. |
The current check is only for title prefix. The accepted prefixes: feat, fix, build, chore, ci, docs, style, refactor, perf, test. Specifying a module (e.g. `(aws-s3)`) is optional, and the subsequent other two characters are `: `.
|
@Mergifyio update |
✅ Branch has been successfully updated |
Preserving past behavior and tests' outcome.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adding the title check for all submitted PRs, not only the breaking change ones. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adding the title check for all submitted PRs, not only the breaking change ones.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license