Skip to content

docs(lambda-event-sources): document different defaults for maxBatchingWindow#21981

Merged
mergify[bot] merged 2 commits intomainfrom
conroy/abc
Sep 9, 2022
Merged

docs(lambda-event-sources): document different defaults for maxBatchingWindow#21981
mergify[bot] merged 2 commits intomainfrom
conroy/abc

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Sep 9, 2022

Fixes #21974


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Sep 9, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 9, 2022 14:27
@github-actions github-actions bot added the p2 label Sep 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 9, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fc098c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 38f8d89 into main Sep 9, 2022
@mergify mergify bot deleted the conroy/abc branch September 9, 2022 15:42
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 9, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Kruspe pushed a commit to DavidSchwarz2/aws-cdk that referenced this pull request Sep 13, 2022
…ngWindow (aws#21981)

Fixes aws#21974


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@yualexan
Copy link
Copy Markdown

Hi, according to this link: https://docs.aws.amazon.com/cdk/api/v1/docs/@aws-cdk_aws-lambda-event-sources.SelfManagedKafkaEventSourceProps.html#maxbatchingwindow, the fix still isn't live. Do you have an idea of when this will be deployed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SelfManagedKafkaEventSourceProps: default maxBatchingWindow incorrect

4 participants