Skip to content

docs(logs-destinations): correctly set package description in README#21570

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
laurelmay:logs-dest-readme
Aug 12, 2022
Merged

docs(logs-destinations): correctly set package description in README#21570
mergify[bot] merged 1 commit intoaws:mainfrom
laurelmay:logs-dest-readme

Conversation

@laurelmay
Copy link
Copy Markdown
Contributor

@laurelmay laurelmay commented Aug 12, 2022

The README uses a "for AWS XXX" description as the main header. This updates that header
to match the format used for the Kinesis Destinations and Lambda Destinations libraries.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 12, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team August 12, 2022 04:53
@github-actions github-actions bot added the p2 label Aug 12, 2022
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 24f2955
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8783ec5 into aws:main Aug 12, 2022
mrgrain added a commit that referenced this pull request Nov 9, 2022
mergify bot pushed a commit that referenced this pull request Nov 9, 2022
…22839)

The README uses a "for AWS XXX" description as the main header. This updates that header
to match the format used for the Kinesis Destinations and Lambda Destinations libraries.

This is a backport of #21570 to v1

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants