Skip to content

chore(config): Config resource type upgrade 202208xx#21491

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
watany-dev:config-resource-type-upgrade-202208xx
Aug 7, 2022
Merged

chore(config): Config resource type upgrade 202208xx#21491
mergify[bot] merged 6 commits intoaws:mainfrom
watany-dev:config-resource-type-upgrade-202208xx

Conversation

@watany-dev
Copy link
Copy Markdown
Contributor

fixes #21477

The original problem was that Supported Resource Types currently does not support resource types.

To solve this problem, type information had to be defined in L2 Constructs. Details are listed in the issue list. (Too many to list again)


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Aug 7, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Aug 7, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 7, 2022 10:39
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(config): Config resource type upgrade 202208xx chore(config): Config resource type upgrade 202208xx Aug 7, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f5f0514
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 618c5bc into aws:main Aug 7, 2022
@watany-dev watany-dev deleted the config-resource-type-upgrade-202208xx branch August 8, 2022 00:28
jmortlock pushed a commit to jmortlock/aws-cdk that referenced this pull request Aug 8, 2022
fixes aws#21477

The original problem was that [Supported Resource Types](https://docs.aws.amazon.com/config/latest/developerguide/resource-config-reference.html) currently does not support resource types.

To solve this problem, type information had to be defined in L2 Constructs. Details are listed in the issue list. (Too many to list again)

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(config): Supported resource types are not up-to-date and missing as of 2022.8.

3 participants