feat(ecs-patterns) add idle timeout to multi alb fargate and ec2 services#21266
Merged
mergify[bot] merged 10 commits intoaws:mainfrom Aug 1, 2022
Merged
feat(ecs-patterns) add idle timeout to multi alb fargate and ec2 services#21266mergify[bot] merged 10 commits intoaws:mainfrom
mergify[bot] merged 10 commits intoaws:mainfrom
Conversation
|
|
4 tasks
Contributor
Author
|
Do not merge until #21261 is completed. |
TheRealAmazonKendra
previously requested changes
Jul 22, 2022
Contributor
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Just assigning this to myself and marking it as changes requested to indicate to my team mates that we're already engaging on this, now split into mulitple PRs.
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
…21261) This PR exposes the idleTime property for both EC2 and Fargate ALB services. [Per the CFN specs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-loadbalancer-loadbalancerattributes.html), I have set the idleTimeout to default to 60 seconds, and it cannot exceed 4000 seconds. If no value is provided we set the value to undefined. We do this because: 1. The default value is set for the user via the CFN. The behavior for the property is to either add a value or leave it undefined and let CFN set the default.[ See here](https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts#L102) 2. Setting a default causes snapshot tests to fail for dependent services as we're adding a new attribute to the cloudformation. A README entry has been created for this property. Relates to #21221 #21266 closes #12913 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Contributor
Author
|
@Mergifyio update |
Contributor
❌ Base branch update has failedDetailsmerge conflict between base and head |
Contributor
Author
|
@Mergifyio update |
Contributor
☑️ Nothing to doDetails
|
Pull request has been modified.
TheRealAmazonKendra
approved these changes
Aug 1, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the idleTime property for both EC2 and Fargate multi ALB services. Per the CFN specs, I have set the idleTimeout to default to 60 seconds, and it cannot exceed 4000 seconds.
If no value is provided we set the value to undefined. We do this because:
The default value is set for the user via the CFN. The behavior for the property is to either add a value or leave it undefined and let CFN set the default. See here
Setting a default causes snapshot tests to fail for dependent services as we're adding a new attribute to the cloudformation.
A README entry has been created for this property.
Relates to
#21221
#21261
closes #12913
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license