Skip to content

chore: handle rejected CFN spec updates#21236

Merged
mergify[bot] merged 2 commits intomainfrom
huijbers/cfnspec-rejections
Jul 19, 2022
Merged

chore: handle rejected CFN spec updates#21236
mergify[bot] merged 2 commits intomainfrom
huijbers/cfnspec-rejections

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jul 19, 2022

Retain rejected spec updates and add a script that can report on the
rejections.

We will add this to a cron job that will create tickets if there are rejected spec updates.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Retain rejected spec updates and add a script that can report on the
rejections.
@rix0rrr rix0rrr requested a review from a team July 19, 2022 16:31
@rix0rrr rix0rrr self-assigned this Jul 19, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 19, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2022 16:32
@github-actions github-actions bot added the p2 label Jul 19, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 19, 2022
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c645aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c25d397 into main Jul 19, 2022
@mergify mergify bot deleted the huijbers/cfnspec-rejections branch July 19, 2022 18:16
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain added the effort/small Small work item – less than a day of effort label Jul 20, 2022
comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
Retain rejected spec updates and add a script that can report on the
rejections. 

We will add this to a cron job that will create tickets if there are rejected spec updates.

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants