Skip to content

docs(rds): typo OracleSe2 is Standard Edition 2#21226

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
WinterYukky:patch-1
Jul 19, 2022
Merged

docs(rds): typo OracleSe2 is Standard Edition 2#21226
mergify[bot] merged 1 commit intoaws:mainfrom
WinterYukky:patch-1

Conversation

@WinterYukky
Copy link
Copy Markdown
Contributor

fix comment in DatabaseInstanceEngine.oracleSe2


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 19, 2022

@github-actions github-actions bot added the p2 label Jul 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2022 11:23
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a953eb6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 19, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4ba51ca into aws:main Jul 19, 2022
@WinterYukky WinterYukky deleted the patch-1 branch July 19, 2022 12:46
@mrgrain mrgrain added the effort/small Small work item – less than a day of effort label Jul 20, 2022
comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
fix comment in `DatabaseInstanceEngine.oracleSe2`

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants