Skip to content

docs(ecs-patterns):fix aws ecs patterns docs#21225

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
Yoshiitaka:fix-typo-aws-ecs-patterns-docs
Jul 20, 2022
Merged

docs(ecs-patterns):fix aws ecs patterns docs#21225
mergify[bot] merged 5 commits intoaws:mainfrom
Yoshiitaka:fix-typo-aws-ecs-patterns-docs

Conversation

@Yoshiitaka
Copy link
Copy Markdown
Contributor


New Features

Fixes: #21027

Fix aws-ecs-patterns doc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jul 19, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2022 10:17
@github-actions github-actions bot added the p2 label Jul 19, 2022
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading is two sections up already. The heading isn't the issue, it's that the code snippet that is incorrect. The piece that should be updated is

const queueProcessingFargateService = new ecsPatterns.QueueProcessingFargateService(this, 'Service', {
  cluster,
  memoryLimitMiB: 512,
  image: ecs.ContainerImage.fromRegistry('test'),
  capacityProviderStrategies: [
    {
      capacityProvider: capacityProvider.capacityProviderName,
    },
  ],
});

@Yoshiitaka
Copy link
Copy Markdown
Contributor Author

Yoshiitaka commented Jul 19, 2022

@TheRealAmazonKendra
Thank you for check this PR.
hm, The headline was certainly not wrong.
I confirmed that there is already a "QueueProcessingFargateService", so I will fix a code snippet to "QueueProcessingEc2Service" :)

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review July 19, 2022 23:26

Pull request has been modified.

@TheRealAmazonKendra TheRealAmazonKendra changed the title docs(aws-ecs-patterns):fix aws ecs patterns docs docs(ecs-patterns):fix aws ecs patterns docs Jul 20, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 44127cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8fcbc2 into aws:main Jul 20, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 20, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
----

### New Features

Fixes: aws#21027

Fix aws-ecs-patterns doc.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib.aws_ecs_patterns): "Set capacityProviderStrategies for QueueProcessingEc2Service" shows a snippet of QueueProcessingFargateService

3 participants